search

GEUS-Glaciology-and-Climate / pypromice

Process AWS data from L0 (raw logger) through Lx (end user)
https://pypromice.readthedocs.io
GNU General Public License v2.0
12 stars 4 forks source link

Fixed issue in get_bufr console script #231

Closed ladsmund closed 2 months ago

ladsmund commented 2 months ago

The updated function get_bufr required explicit parameters instead of command line arguments. The function get_bufr.main is used instead.

PennyHow commented 2 months ago

I'm just checking this new console script works in our processing pipeline. It's strange, the repo unit tests are taking a really long time to run. Not sure why.

PennyHow commented 2 months ago

I'm just checking this new console script works in our processing pipeline. It's strange, the repo unit tests are taking a really long time to run. Not sure why.

Now I know why. GEUS Dataverse is down and one of the unit tests requres it to pull from here, so it is a connection timeout.

PennyHow commented 2 months ago

All seems to be working when I implement these changes and update the get_bufr command in our L3 processor script:

get_bufr --input_files DIR --bufr-out DIR--timestamps-pickle-filepath FILE --positions --positions-filepath FILE

So I am happy with this PR. You can go ahead and merge it @ladsmund, and just bypass the unit test checks for now as we know why they are not passing.