Relative humidity min/max, clipping and OOL - Githubissues

GEUS-Glaciology-and-Climate / pypromice

Process AWS data from L0 (raw logger) through Lx (end user)

https://pypromice.readthedocs.io

GNU General Public License v2.0

14 stars 4 forks source link

Relative humidity min/max, clipping and OOL #309

Open ladsmund opened 3 weeks ago

ladsmund commented 3 weeks ago

The clip_values function currently restricts rh_[uli]_cor to the range of 0 to 100.

Is this approach valid, given that the allowable range for these values was initially set between 0 and 150%, accommodating supersaturated states?

Would it be more appropriate to validate and filter the inferred values before computing the corrected humidity variables? Clipping might be overly restrictive in cases where supersaturation is expected or meaningful.

https://github.com/GEUS-Glaciology-and-Climate/pypromice/pull/307#pullrequestreview-2354291734

BaptisteVandecrux commented 3 weeks ago

To me there is no doubt that

rh_[uli] should have a range of 0-100
rh_[uli]_cor should have a range of 0-150 to allow supersaturation
the following lines have been identified as dysfunctional (#220) and shouldn't be brought back into https://github.com/GEUS-Glaciology-and-Climate/pypromice/pull/307:

https://github.com/GEUS-Glaciology-and-Climate/pypromice/blob/a46e96e8e6e428fd3c5bee8bde12128082a596ce/src/pypromice/process/value_clipping.py#L45-L52

Would it be more appropriate to validate and filter the inferred values before computing the corrected humidity variables?

I am not sure what you are suggesting here.