search

GEUS-Glaciology-and-Climate / pypromice

Process AWS data from L0 (raw logger) through Lx (end user)
https://pypromice.readthedocs.io
GNU General Public License v2.0
14 stars 4 forks source link

Sun angle calculations for low angles #35

Open mankoff opened 3 years ago

mankoff commented 3 years ago

I think the current sun angle calculations assume a perfect sphere? For low sun angles, it may matter that the station is at elevation on a sloped ice sheet surface with local horizon in one direction much closer than local horizon in another.

PennyHow commented 1 year ago

Sun angle calculations can currently be found here:

https://github.com/GEUS-Glaciology-and-Climate/pypromice/blob/2331c02e1e121648c06dd054d370f0b99a6a8f6d/src/pypromice/L1toL2.py#L67-L71

And I think the perfect sphere assumption comes in here, maybe?:

https://github.com/GEUS-Glaciology-and-Climate/pypromice/blob/2331c02e1e121648c06dd054d370f0b99a6a8f6d/src/pypromice/L1toL2.py#L348-L353

I don't have any reference or citation to where this calculation comes from, and I don't know of any alternatives calculations for now.