Closed patrickjwright closed 1 year ago
Latest commit https://github.com/GEUS-Glaciology-and-Climate/pypromice/pull/72/commits/07cd5e3cda2fda2d7881f89e8dae122b686c8606 switches to bin/getBUFR
as a command line script. This involved:
args.py
into parse_arguments()
directly in getBUFR
.csv2bufr.py
down to only the functions. Functions called in getBUFR
are imported as modules.__init__.py
to the postprocess
directory so that modules are importable from this locationgetBUFR
and csv2bufr.py
to only the imports needed in each script.csv2bufr.py
Long-running branch to develop code for submitting near real-time observations to DMI and WMO.
This was based off original code contained in
csv2bufr.py
but has been significantly changed.The goal was to have all configuration accessible in
args.py
andwmo_config.py
(e.g. for changing file paths, common variables, stations to skip, and all BUFR settings). Otherwise, docstrings and comments throughout the code should suffice to orient a new developer to the code.wmo_config.py
takes the approach of using dictionaries as config objects (rather than a csv file, etc). I find this to be more readable and easier to edit.In addition to the work on generating WMO BUFR files, this PR includes the following:
msg_lat
andmsg_lon
strings that are picked up from emails and carried through the code. These are currently also written toaws-l3/level_3
files in addition totx
files, so we may want to remove those columns fromlevel_3
?We will also be merging three other branches that were merged into the
wmo-bufr
branch:dev-pho
,modify-time-shift
andl3-file-names
.It would be good to add some basic information to the
pypromice
README regardingcsv2bufr.py
. And perhaps a more detailed entry to https://geus-glaciology-and-climate.github.io/ to explain background, general methodology and how to run the code would be good?