GEUS-Glaciology-and-Climate / pypromice

Process AWS data from L0 (raw logger) through Lx (end user)
https://pypromice.readthedocs.io
GNU General Public License v2.0
12 stars 4 forks source link

wmo-bufr #72

Closed patrickjwright closed 1 year ago

patrickjwright commented 1 year ago

Long-running branch to develop code for submitting near real-time observations to DMI and WMO.

This was based off original code contained in csv2bufr.py but has been significantly changed.

The goal was to have all configuration accessible in args.py and wmo_config.py (e.g. for changing file paths, common variables, stations to skip, and all BUFR settings). Otherwise, docstrings and comments throughout the code should suffice to orient a new developer to the code. wmo_config.py takes the approach of using dictionaries as config objects (rather than a csv file, etc). I find this to be more readable and easier to edit.

In addition to the work on generating WMO BUFR files, this PR includes the following:

We will also be merging three other branches that were merged into the wmo-bufr branch: dev-pho, modify-time-shift and l3-file-names.

It would be good to add some basic information to the pypromice README regarding csv2bufr.py. And perhaps a more detailed entry to https://geus-glaciology-and-climate.github.io/ to explain background, general methodology and how to run the code would be good?

patrickjwright commented 1 year ago

Latest commit https://github.com/GEUS-Glaciology-and-Climate/pypromice/pull/72/commits/07cd5e3cda2fda2d7881f89e8dae122b686c8606 switches to bin/getBUFR as a command line script. This involved: