search

GEUS-Glaciology-and-Climate / pypromice

Process AWS data from L0 (raw logger) through Lx (end user)
https://pypromice.readthedocs.io
GNU General Public License v2.0
14 stars 4 forks source link

use UTC time on glacio01, processor script #75

Closed patrickjwright closed 1 year ago

patrickjwright commented 1 year ago

The processor script reports local CPH time when running: Running l3_processor at 2022-12-21 10:05:02

At the time this run took place, CPH time was 10:05, UTC time was 0905.

This is confusing since all other references with the stations should be in UTC.

PennyHow commented 1 year ago

This line in the processor script reports the start time:

echo "Running l3_processor at `/bin/date +%Y-%m-%d\ %T`"

We could change this to report UTC time instead, like this:

echo "Running l3_processor at `date -u`"

And also adopt this for the commit messages.

PennyHow commented 1 year ago

I tested this on our server and it seems to work fine. Commit messages on aws-l3-dev now state e.g.

L3 update Thu Jan 12 19:12:21 UTC 2023

The only thing I'm thinking is do we want this datetime formatted differently? For example, yyyy/mm/dd hh:mm:ss UTC.

patrickjwright commented 1 year ago

@PennyHow this looks great, thanks for looking into it. I don't feel strongly one way or the other about the format. For changes to the processing script, they need to be implemented on both Azure and glacio01 (and updated in the aws-l3 README). Maybe that script should be in version control at some point?

PennyHow commented 1 year ago

Yes, I only put it on glacio01 just to see it worked. I'll put it on Azure also now.

As for the version control on our .sh scripts, I think this is a good idea. Maybe we should set up a separate repo for this.

patrickjwright commented 1 year ago

Yeah, seems a bit silly to have an entire repo for a small shell script, but maybe this is the best way forward? We could also include the bufr_wrapper.sh script.

PennyHow commented 1 year ago

And the tx message grabber and back-up.

PennyHow commented 1 year ago

A private repo aws-operational-processing has been created.