search

GEUS-Glaciology-and-Climate / pypromice

Process AWS data from L0 (raw logger) through Lx (end user)
https://pypromice.readthedocs.io
GNU General Public License v2.0
14 stars 4 forks source link

Directional wind speed should be moved to L1toL2 instead of L0toL1 #97

Closed BaptisteVandecrux closed 1 year ago

BaptisteVandecrux commented 1 year ago

Currently it is done in L0toL1, before any filtering or adjustment of the wind direction that should will take place in L1toL2. I recommend moving it to L2toL3 since it is a "derived variable".

https://github.com/GEUS-Glaciology-and-Climate/pypromice/blob/480a77316bacacb0055d14368e00b54b54a68040/src/pypromice/L0toL1.py#L100

https://github.com/GEUS-Glaciology-and-Climate/pypromice/blob/480a77316bacacb0055d14368e00b54b54a68040/src/pypromice/L0toL1.py#L116

https://github.com/GEUS-Glaciology-and-Climate/pypromice/blob/480a77316bacacb0055d14368e00b54b54a68040/src/pypromice/L0toL1.py#L121

PennyHow commented 1 year ago

Yes. This step should be in L2toL3. Perhaps it could come just before deriving wdir from the directional wind speed wspd_x wspd_y.

https://github.com/GEUS-Glaciology-and-Climate/pypromice/blob/480a77316bacacb0055d14368e00b54b54a68040/src/pypromice/L2toL3.py#L34 https://github.com/GEUS-Glaciology-and-Climate/pypromice/blob/480a77316bacacb0055d14368e00b54b54a68040/src/pypromice/L2toL3.py#L61 https://github.com/GEUS-Glaciology-and-Climate/pypromice/blob/480a77316bacacb0055d14368e00b54b54a68040/src/pypromice/L2toL3.py#L86

We would just need to rename L2toL3._calcWindDir as this is the same name as L0toL1._calcWindDir. Perhaps L0toL1._calcWindDir should be changed to L2toL3._calcWspdDir.

BaptisteVandecrux commented 1 year ago

Fixed with #172