search

GEWIS / gewisdb

GEWIS Decision and Members Database
GNU General Public License v3.0
8 stars 7 forks source link

Incorrect `SubDecision` property returned in Report #393

Closed tomudding closed 4 months ago

tomudding commented 4 months ago

Current behaviour

GEWISWEB had issues with getDecisionNumber() in the files of the Report module as described in https://github.com/GEWIS/gewisweb/pull/1647. It was believed that this was fixed in GEWISDB. Unfortunately it was only fixed in Database and not in Report:

https://github.com/GEWIS/gewisdb/blob/bcc33473cf8ba01c3b02fbd07caf47fed010722f/module/Report/src/Model/SubDecision.php#L200-L206

Desired behaviour

Should return decision_number to prevent copy/paste issues with GEWISWEB.

Steps to reproduce

N/A

Database version

bcc33473cf8ba01c3b02fbd07caf47fed010722f

What operating are you seeing the problem on?

No response

What browsers are you seeing the problem on?

No response

Other information

No response