GEWIS / gewisdb

GEWIS Decision and Members Database
GNU General Public License v3.0
8 stars 7 forks source link

Signal through the API that modifications are being made #397

Closed rinkp closed 4 months ago

rinkp commented 4 months ago

Description

  1. Improves the notifications (such as pending updates and sync pause) on the home page
  2. Introduces notification counter to draw attention to the home page
  3. Pauses sync API when decisions are created. 15 minutes is deemed reasonable. If no decisions are entered for more than 15 minutes, the secretary most likely is done entering decisions for that specific meeting.
  4. Pauses sync API when decisions are deleted. 60 minutes on deletion to prevent accidentally deleting organs in other systems. Impact of a 60 minute sync delay is considered minimal while hardly any decisions are ever deleted
  5. Bugfixes

image

Related issues/external references

Fixes GH-389.

Types of changes

rinkp commented 4 months ago

Psalm locally:

image

The PHPUnit tests are caused by the Notification helper. It loads FrontPageService which needs the ApiService which needs the MemberMapper from reportdb

tomudding commented 4 months ago

PHPStan locally: image

rinkp commented 4 months ago

The phpstan issue seems to be related due to incompatibility between main and the new branch because of renaming database_doctrine_em.

Psalm will no longer complain if psalm.xml is modified in a PR