search

GEWIS / gewisdb

GEWIS Decision and Members Database
GNU General Public License v3.0
8 stars 7 forks source link

Making a `Member` `external` should use `membershipEndsOn` at the end of the current association year. #420

Closed tomudding closed 2 months ago

tomudding commented 3 months ago

Current behaviour

Manually changing someone's membership type to external sets the membershipEndsOn to the start of the current association year.

Desired behaviour

The membershipEndsOn should be at the end of the current association year for externals.

Steps to reproduce

Make someone external observe membershipEndsOn is in the past instead of the future.

Database version

latest

What operating are you seeing the problem on?

No response

What browsers are you seeing the problem on?

No response

Other information

Follows from ABC-2407-095.

rinkp commented 3 months ago

Maybe we should rethink the entire UI of showing this and extending this. I am thinking of adding a date field when clicking update/renew

tomudding commented 3 months ago

Maybe we should rethink the entire UI of showing this and extending this. I am thinking of adding a date field when clicking update/renew

I do not think this is necessary; perhaps the form needs some clarification, but with this fixed, everything behaves the same. All changes are applied as if this was the case on July 1st (start of the current association year).