GEWIS / gewisdb

GEWIS Decision and Members Database
GNU General Public License v3.0
8 stars 7 forks source link

House number regex too restrictive #438

Closed tomudding closed 1 month ago

tomudding commented 1 month ago

Current behaviour

The regex is too restrictive:

https://github.com/GEWIS/gewisdb/blob/1a99c3493da05f8976193f825c62bf2ae7139a8f/module/Database/src/Form/Address.php#L117

Desired behaviour

Should allow at least also - and /.

Steps to reproduce

N/A

Database version

latest

What operating are you seeing the problem on?

No response

What browsers are you seeing the problem on?

No response

Other information

No response

tomudding commented 1 month ago

There are of course two Forms with different definitions:

https://github.com/GEWIS/gewisdb/blob/8174b3ba65c5ad70172009bdfaa6d86adfb7440f/module/Database/src/Form/Fieldset/Address.php#L139