GEWIS / gewisweb

GEWIS Website
https://gewis.nl
GNU General Public License v3.0
16 stars 34 forks source link

Improve approve organ page #1383

Open LeonVreling opened 2 years ago

LeonVreling commented 2 years ago

Currently, the board needs to approve changes an organ makes to their page on the GEWIS website. This process is, however, not that nice in my personal experience.

One thing that could be improved is a preview of the image that you are approving, cause now you can only view the text. We could maybe make a new page that shows the old version on the left side, and the new proposed changes on the right side. This also makes the checking of the text easier.

Let me know what you think about this 😄

tomudding commented 2 years ago

I have always wanted to properly implement a Git-like diff system (which would also be used in the Activity module), however, I have not found a package that can do this for natural text (and I most certainly do not have the time to implement something like that myself).

If we get something working, we can also use it in the upcoming update to the company module, as that also heavily relies on diffs.

tomudding commented 2 years ago

~Perhaps lolli42/finediff can do the diff thing, however, images might be a bit more difficult.~

tomudding commented 2 years ago

jfcherng/php-diff is probably the best package we can get if we want to do this in PHP. We can potentially also move this to something JavaScript based (if performance becomes an issue).

tomudding commented 1 year ago

image

Side by side for larger HTML-based textual diffs. Inline for simple text diffs. Unified/combined for single line diffs.