search

GEWIS / gewisweb

GEWIS Website
https://gewis.nl
GNU General Public License v3.0
16 stars 33 forks source link

Work towards supporting Laminas ServiceManager v4 #1638

Open Koen1999 opened 1 year ago

Koen1999 commented 1 year ago

What would you like?

Please see https://github.com/laminas/laminas-servicemanager/releases/tag/4.0.0-rc1

Why is this needed?

Early testing might help fix bugs upstream.

Other information

No response

tomudding commented 1 year ago

Great to see they are making progress on this, before we start testing this we should fully implement the changes required by GEWIS/gewisphp-coding-standards (I have already started on this, this is already fully implemented in GEWISDB). This will allow us to write better code and easily allow us to determine whether something is our fault or something is broken upstream.

tomudding commented 1 year ago

https://docs.laminas.dev/laminas-servicemanager-migration/ already has some migration details, the FactoryInterface for Psr is going to be interesting, because we currently utilise it to handle the ACL:

https://github.com/GEWIS/gewisweb/blob/23a5638b84f678107e37ba03538c418a5ede6b0c/module/User/src/Authorization/AclServiceFactory.php#L37-L41

https://github.com/GEWIS/gewisweb/blob/23a5638b84f678107e37ba03538c418a5ede6b0c/module/User/src/Authorization/AclServiceFactory.php#L55-L56

tomudding commented 6 months ago

v4.0 is out, see https://github.com/laminas/laminas-servicemanager/releases/tag/4.0.0. It will take some time before all components are compatible (or are marked as abandoned because that is the general direction Laminas MVC seems to be going).

tomudding commented 1 month ago

Based on the TSC meetings over the past 9-ish months, it is very likely we will never be able to upgrade to version 4.0 (or later) of the service manager due to decreasing contributions to the whole of Laminas. The current bottleneck is laminas-mvc (and thus the whole framework) with many of its dependencies (components) not receiving updates.

Koen1999 commented 1 month ago

Based on the TSC meetings over the past 9-ish months, it is very likely we will never be able to upgrade to version 4.0 (or later) of the service manager due to decreasing contributions to the whole of Laminas. The current bottleneck is laminas-mvc (and thus the whole framework) with many of its dependencies (components) not receiving updates.

Bit sad it might die like that. It's not a bad framework, but I guess it suffers from competition. As long as we receive security updates we should be okay though. I don't think there's any functionality we are really missing at the moment.