search

GEWIS / gewisweb

GEWIS Website
https://gewis.nl
GNU General Public License v3.0
16 stars 33 forks source link

Move away from `maglnet/magl-markdown` #1755

Closed tomudding closed 7 months ago

tomudding commented 8 months ago

What would you like?

As mentioned in GH-1482 we should move away from maglnet/magl-markdown due to lack of updates.

I will make a markdown view helper in the Application module using michelf/php-markdown (updated) or league/commonmark (as that also support GHF markdown).

Why is this needed?

Prevent issues with dependencies (and their dependencies not being up-to-date).

Other information

No response

tomudding commented 7 months ago

league/commonmark should have the following settings:

[
    'html_input' => 'escape',
    'allow_unsafe_links' => false,
]

NOTE: this will break a lot of existing activity descriptions that abuse HTML. As such, before deploying we should (try to) convert existing HTML in the descriptions to Markdown.