Fix ordering of functions for committees and organs

GEWIS / gewisweb

GEWIS Website

https://gewis.nl

GNU General Public License v3.0

16 stars 33 forks source link

Fix ordering of functions for committees and organs #1795

Closed tomudding closed 3 months ago

tomudding commented 3 months ago

Ordering is now guaranteed to follow:

Chair
Secretary
Treasurer
Vice-Chair

If someone has multiple functions then the highest function is used for the actual ordering. So someone who is both secretary and vice- chair will be above someone who is treasurer. Likewise, if someone is treasurer and vice-chair they will still be ranked below chair and secretary.

Fixes GH-1791.

tomudding commented 3 months ago

Last PHP_CodeSniffer issue is not a problem, as we do not yet have the latest version it detects the type of the const as the name.