GEWIS / gewisweb

GEWIS Website
https://gewis.nl
GNU General Public License v3.0
16 stars 33 forks source link

Do not show 'update subscription' if sign-up list has no fields #1805

Closed tomudding closed 6 months ago

tomudding commented 6 months ago

Current behaviour

Currently, the "update subscription" button and modal are always shown when a member can still update their subscription.

image

Desired behaviour

The button and modal should not be accessible/work when the sign-up list for that subscription does not have any fields. The reasoning for this is that there is nothing to update for that subscription.

Ideally, we also add a check for this in signupAction().

Steps to reproduce

1) Create an activity with a sign-up list that does not have any fields. 2) Subscribe to that activity. 3) 'Update subscription'-button and modal are shown

Website version

69b45e7958c0347871c3c6a1afd5f503a0a7c99d

What operating are you seeing the problem on?

No response

What browsers are you seeing the problem on?

No response

Other information

No response