GEWIS / gewisweb

GEWIS Website
https://gewis.nl
GNU General Public License v3.0
16 stars 33 forks source link

Fix ordering of `BoardMember`s with multiple functions in the same association year #1853

Open tomudding opened 3 days ago

tomudding commented 3 days ago

Current behaviour

Ordering is based on the decision and does not account for any ordering in the same associatio year. The reason for this is of course that at the time of implementation we did not have any cases (in GEWISDB) where a board member had multiple functions.

https://github.com/GEWIS/gewisweb/blob/8b3cbe186f92b3294d9b6ad260e8970fefe420b9/module/Decision/view/decision/member/view.phtml#L65

Desired behaviour

Ordering on function within the same meeting; chair -> secretary -> treasurer. Any other function comes after this and remains unsorted.

Steps to reproduce

See current board.

Website version

8b3cbe1

What operating are you seeing the problem on?

No response

What browsers are you seeing the problem on?

No response

Other information

No response