GEWIS / sudosos-backend

SudoSOS is a Node.js-based Bar and POS system made for study association GEWIS.
https://sudosos.gewis.nl
GNU Affero General Public License v3.0
4 stars 3 forks source link

[BUG] BasePointOfSaleResponse spec is wrong #115

Open JustSamuel opened 8 months ago

JustSamuel commented 8 months ago

The Spec does not contain useAuthentication and revision, however the function parsePOSToBasePOS in the revision-to-response always adds these. This mistake crept in because we force the return value to the type.

This is a simple fix, but simply changing the type does add some type errors here and there. The fixes are either always adding the revision and authentication, or making them optional, or removing them all together.

For now I have set dissalowExtraProperties to false in the transaction-controller.ts test cases to make sure they pass.

JustSamuel commented 8 months ago

Same goes for the TransactionReportResponse

JustSamuel commented 8 months ago

TODO fix test cases