Deleting a fine, resulting in positive balance, doesn't remove fine status

GEWIS / sudosos-backend

SudoSOS is a Node.js-based Bar and POS system made for study association GEWIS.

https://sudosos.gewis.nl

GNU Affero General Public License v3.0

4 stars 3 forks source link

Deleting a fine, resulting in positive balance, doesn't remove fine status #137

Closed CodeNamedRobin closed 2 months ago

CodeNamedRobin commented 7 months ago

Situation: A user has multiple fines and has a balance just under 0. One fine is deleted, putting the user in a positive balance. Expected: The user has all fines marked as paid off. Actual: The user is still in a fined status. Proof: WhatsApp Image 2024-01-12 at 18 52 11_51c1716c

JustSamuel commented 7 months ago

Clearly the easier solution: https://github.com/GEWIS/sudosos-frontend-vue3/tree/bugfix/hide-fine-on-positive

Yoronex commented 7 months ago

Should in my opinion still be resolved on the backend, because it will also show on the "Schandpaal" in the room