Closed JustSamuel closed 4 months ago
github-actions[bot]
commented
7 months ago Commit: 27a3c17 Base: develop@6446057
| Type | Base | This PR |
|---|---|---|
| Total Statements Coverage | ? |  89.16% (?) |
| Total Branches Coverage | ? | 83.67% (?) |
| Total Functions Coverage | ? | 90.28% (?) |
| Total Lines Coverage | ? | 89.05% (?) |
| File | Statements | Branches | Functions | Lines |
|---|
JustSamuel
commented
7 months ago Self: make sure to add a todo / issue to fix the parallelism if that turns out to be the issue,
JustSamuel
commented
7 months ago Still not ready; needs a database migration to work.
github-actions[bot]
commented
2 months ago :tada: This PR is included in version 0.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
50%
33.33%
Adds the ability to generate PDF's for invoices using the PDF-generator. The parameters of these invoices are hashed as to not recompile if nothing changed.
This PR also implements InvoiceUsers which allow defaults to be saved for users when creating an invoice. That is, if a user is of type
INVOICEit will use the stored properties,street,postalCode,cityandcountry. Ifaddresseeis not provided it will default to the invoiced users' full name.TODO:
Fixes #13. Fixes #90
Migration plan
Since this PR adds quite a lot of columns to the Invoices table which are not nullable and do not have a default value I suggest the followings.
When migrating we give these columns a temporary placeholder value like "MIGRATION_DEFAULT". After the migration we fill the InvoiceUser table and replace the values in the invoice with those. For the reference we should simply do some manual work.