github-actions[bot]
commented
5 months ago SudoSOS Coverage Report
Commit: a760f08 Base: develop@7382d62
| Type | Base | This PR |
|---|---|---|
| Total Statements Coverage | ? |  90.09% (?) |
| Total Branches Coverage | ? | 85.7% (?) |
| Total Functions Coverage | ? | 91.22% (?) |
| Total Lines Coverage | ? | 90.07% (?) |
Details (changed files)
| File | Statements | Branches | Functions | Lines |
|---|
50%
33.33%
The MySQL test suite now finally works. Some changes were needed such to never close a connection if we are in a MySQL context.
The original mistake originated from the test/setup.ts file where the env vars were overwritten and always resulted in a sqlite context.
This PR also includes multiple bug fixes found during this process.
Changes
To ensure future test cases also work make sure to use the following in your
beforeAnd the following in your after
This also means to speed up the testing, refrain from making this a
beforeEach.TODO
Fixes & Closes
CI: Adds post migration test suite. fix:
Invoicemigration, such that it follows the current schema synchronize. fix:product-revision.alcoholPercentagehad precision: 0. fix: bug in balance service that would crash mysql on empty ids array. fix:FineHandoutEventswere not sorted by default fix:EventServicefiltering onbeforeDatewas wrong fix:InvoiceServicelatest valid invoice function was wrong fix: MySQL didn't store milliseconds for timestamps. fix: seed script for MySQL.Closes #82 Closes #83 Closes #88