search

GEWIS / sudosos-backend

SudoSOS is a Node.js-based Bar and POS system made for study association GEWIS.
https://sudosos.gewis.nl
GNU Affero General Public License v3.0
3 stars 3 forks source link

fix: `StripeController` test with too high test balance #181

Closed tomudding closed 1 month ago

tomudding commented 1 month ago

Analysis shows that the seedStripeDeposits can/will create 3 valid Stripe deposits resulting in a balance of 117 euros. A top-up of another 39 euros will thus fail as this exceeds the 150 euro balance limit.

Instead of changing the seeding (which may inadvertantly affect other tests) we simply change the amount of the top-up to €19.50.

Fixes GH-180.

tomudding commented 1 month ago

@JustSamuel if necessary I can also add two other tests to check the minimum and maximum tests.

JustSamuel commented 1 month ago

@JustSamuel if necessary I can also add two other tests to check the minimum and maximum tests.

Sure, why not

github-actions[bot] commented 2 weeks ago

:tada: This PR is included in version 0.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: