Closed SuperVK closed 5 months ago
github-actions[bot]
commented
5 months ago Commit: fc3db06 Base: develop@6e8e3dd
| Type | Base | This PR |
|---|---|---|
| Total Statements Coverage | ? |  90.13% (?) |
| Total Branches Coverage | ? | 85.73% (?) |
| Total Functions Coverage | ? | 91.22% (?) |
| Total Lines Coverage | ? | 90.11% (?) |
| File | Statements | Branches | Functions | Lines |
|---|
JustSamuel
commented
5 months ago And you suggest instead using a GET transactions to find which transactions a user created that were not for him? iirc you cant filter the user out so that would have duplicates?
Or do you think its not needed anymore that a user can see which transactions were created in his name for someone else?
SuperVK
commented
5 months ago Exactly this point was a problem in my head as well. I do think being to see which transactions you created is needed. I think a filter per POS will solve, because somebody from the BAC or from BOOM can filter on their respective POS and mostly see transactions made for others, rarely for themselves. However if you filter on "BAC Verkoop" you will still a lot of yourself, so i am not sure about that.
JustSamuel
commented
5 months ago You can merge it imho, but if you need a follow up, please create an issue now.
github-actions[bot]
commented
4 months ago :tada: This PR is included in version 0.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
50%
33.33%
Remove transactions created by the user from the transactions overview of the user (as well as the financial mutation)
Description
Currently, financial mutations and transactions on
/user/{id}/transactionsand/user/{id}/financialmutationsreturn also transactions that are created by the user. This PR removes that functionality. The idea is that all the financial mutation (transactions, transfers, and financialmutation) on the/user/*should only return transactions/transfers that mutate the user's balance.This is also tied into the frontend, where it would only make sense to display only transactions that influence the balance of the user together, serving the purpose of being able to see why you are €-15 when you topped up a week ago. Transactions that are created by the user should be displayed in a separate view because it serves a different purpose (namely, looking back at who you bought for in case someone comes knocking after an event).
Related issues/external references
This also solves (not fixes) the need for #157, because now transactions/transfers from users will actually be treated in a different way than transactions from an endpoint. They will get different views based on their purpose (seeing influences or your balance, or administratively what transactions happened on a PoS or by a user).
Types of changes