github-actions[bot]
commented
2 months ago SudoSOS Coverage Report
Commit: cf504da Base: develop@825e45f
| Type | Base | This PR |
|---|---|---|
| Total Statements Coverage |  86.27% |
86.44% (+0.17%) |
| Total Branches Coverage | 84.8% |
84.58% (-0.22%) |
| Total Functions Coverage | 87.78% |
88.08% (+0.3%) |
| Total Lines Coverage | 86.32% |
86.5% (+0.18%) |
Details (changed files)
| File | Statements | Branches | Functions | Lines |
|---|
50%
33.33%
Description
Implements a new Sales Reporting function, as described in https://github.com/GEWIS/sudosos-backend/issues/260 and marked as a TODO here https://github.com/GEWIS/sudosos-backend/pull/259.
This is SO much faster. It is not even funny, aggregating the whole database is instant. This is because the new service writes queries instead of fetching data and computing the statistics itself. This is how it should always have but the previous reporting function got some scope creep to try and make it more versatile.
This leaves the old reporting untouched, for backwards compatability.
Related issues/external references
Types of changes