Open SvenMokveldje opened 1 month ago
SvenMokveldje
commented
1 month ago For the test fails: The first one, I do not understand why the post-miration-test tries to equal it to 20, as the default_pagination should be either that of process.env which is 20 or the default put in by Samuel which is 25.
The second one, does not fail on my machine (hihi), but as I take a id bigger than that should exist it should be equal to null. But maybe someone with more knowledge can take a crack at it.
github-actions[bot]
commented
1 month ago Commit: 956cd0a Base: develop@38c5d00
| Type | Base | This PR |
|---|---|---|
| Total Statements Coverage |  85.21% |
85.09% (-0.12%) |
| Total Branches Coverage | 81.42% |
80.93% (-0.49%) |
| Total Functions Coverage | 87.44% |
87.35% (-0.09%) |
| Total Lines Coverage | 85.55% |
85.48% (-0.07%) |
| File | Statements | Branches | Functions | Lines |
|---|
Yoronex
commented
1 month ago Please rebase your branch on the develop branch. Your PR includes for example all the changes I made in the dependency update, which should not be part of this PR (as it is already present in develop). Not sure why this goes wrong, but please try to rebase instead of merging develop into your own branch when it is outdated.
SvenMokveldje
commented
1 month ago @JustSamuel @Yoronex, I think I have implemented your changes. Please check :)
20%
50%
Created the inactive administrative cost feature. BAC treasurer can now check who has been inactive at SudoSOS and either send them an notification and after 3 years fine them. This will fine them until they have a balance of 0. After which the BAC treasurer can disable those accounts.
(Auto locking will be added once this is implemented)
You can check inactive users, notify them, handout the administrative costs, create the inactive administrative cost entity and delete it. There is no update function as you would never change the amount (this is fixed) so the only update would be to delete it and lastly get certain entities.