search

GEWIS / sudosos-backend

SudoSOS is a Node.js-based Bar and POS system made for study association GEWIS.
https://sudosos.gewis.nl
GNU Affero General Public License v3.0
6 stars 3 forks source link

Refactor Pagination to Generic Type #85

Open JustSamuel opened 1 year ago

JustSamuel commented 1 year ago

Instead of having PaginatedBannerResponse we should refactor it to be Paginated<BannerResponse> using TypeScripts Generics. Cleaner, and less clutter.

Yoronex commented 1 year ago

This is indeed cleaner and makes pagination much easier to use, but won't we still need to excplicitly define a PaginatedBannerResponse entity for the Swagger spec?