search

GEWIS / sudosos-frontend

This monorepo contains all frontend projects and shared code for the SudoSOS platform, built with Vue 3 and TypeScript. Contributions are welcome!
https://sudosos.gewis.nl
5 stars 4 forks source link

fix: remove topup warning on landing page #438

Closed JustSamuel closed 3 weeks ago

JustSamuel commented 3 weeks ago

Description

After @tomudding his fix for #435 with PR #436 I think its fine to remove the warning. I also thought about changing the text, but people don't read the message anymore since it has been there for quite a while. Removing it will be the clearest message, and will most likely entice people to let us known if it still fails.

Related issues/external references

Types of changes

SuperVK commented 3 weeks ago

My original idea to change that v-if=true to v-if=false, then if we have another message at some point we can easily change the text, and don't have to reinvent the wheel (ideally we incorporate this in some backend feature that we can easily switch).

JustSamuel commented 3 weeks ago

My original idea to change that v-if=true to v-if=false, then if we have another message at some point we can easily change the text, and don't have to reinvent the wheel (ideally we incorporate this in some backend feature that we can easily switch).

I guess, but that is more clutter for something that can be very easily resolved. I suggest we do a general messaging motd system in the backend that we display.