search

GF-Corporate-Archives / gf-johann-conrad-fischer

Reisetagebücher
2 stars 2 forks source link

link to page on e-rara.ch in english versions #518

Closed feggimann closed 11 months ago

feggimann commented 11 months ago

I just noted that the pop-up with the page number and link to e-rara.ch in the english versions reads "Seite xx" instead of "page xx". Please change to english. Thank you

Bildschirmfoto 2023-12-06 um 21 17 31
HelenaSabel commented 11 months ago

@feggimann: done and deployed!

feggimann commented 11 months ago

@HelenaSabel thank you. Can you please use lower case p for page?

HelenaSabel commented 11 months ago

With the lower case p, I thought it didn’t looked very legible because of the underline.

image

How about without being underline? I personally think that with the symbol for the external link it’s already clear that it’s a link without the need of additional formatting. What do you think @feggimann?

image

feggimann commented 11 months ago

yes, this looks fine without the underline, also in German. Thank you