Closed stufraser1 closed 7 years ago
@fjacon please can you action the changes to the geonode homepage (adding icons, data categories) in this and other high priority issues? We need these updates before we start marketing the geonode more heavily, which we would like to start. Thanks
@stufraser1 I'm working on adding new icons. I notice that landslide icon has wrong size: 120px instead of 64px. I can reduce 120px image size but we could have better result if we start from image source. So do you have landslide icon with big resolution ?
I also had to adjust color of new icons to match other icons color: Original color of new icon: New icon with color that match other icons color:
Original LS icon is contained here, colour will need updating too DisasterIcons.zip
Zip archive does not contains current icon for landslide:
Ah yes, I supplied the icon used in TH. We should take this chance to match the geonode icons to those used for TH! and RODI sites - see below, and in the TH code. @vdeparday do you agree?
@Vampouille this would mean updating the river FL and coastal FL icons too - icons in this PDF as well as in TH code: disaster_icon_june_2015_C.pdf
CURRENT GEONODE CURRENT RODI SITE CURRENT TH
Done with: https://github.com/Vampouille/geonode/commit/d9469cf11764d04eda6f3fd0c8aed977917c6d93 and build in docker image camptocamp/geonode_django:20171019113544 and camptocamp/geonode_django:2.7-gfdrr-ac3ab00-psycopg2.7
I just install it on int instance, run a python manage.py collectstatic
to deploy static files and run python manage.py migrate
to migrate database.
TODO: update river FL and coastal FL icon to match TH layout.
Also applied on prod instance
I see a layout issue on chrome with the new icons:
I cannot reproduce on chrome Version 62.0.3202.62. But i am on Ubuntu.
It appears when width of browser window is less than 1200px. @tonio any idea about this layout issue ?
Set a height for every grid item (.col-xs-4.col-sm-3
). Having the same height will avoid floating items to snap on tallest elements (15em
seems to be a good value).
To Do:
When these are live this issue can be closed
@stufraser1 In order to sync icons between TH and geonode, I have use same method as TH to include icons: use a dedicated font that include all icons : https://github.com/GFDRR/thinkhazard/tree/master/thinkhazard/static/webfonts/thinkhazard/fonts This way, we have only one file to update for all icons and this file is share between TH and geonode. I think this is the best way to keep icon synced between TH and geonode. But I did not realize that "drought" icon is missing from font. Do you have an newer font with "drought" icon ?
About layout issue, it's fixed by : 734efa0bc43d854e778e67cbd0687b423a08b115 But not already deployed.
RE 'Do you have an newer font with "drought" icon ?' We only use Water scarcity in TH!, so we do not have the geonode drought icon in TH. Can you include the Drought icon (the dying plant and land) into the TH file, without implementing it in the UI? In the future we may want to add that as a separate hazard, as it is distinct from water scarcity (for clarity, the tap icon) so it may be helpful to have it in there.
Can you include the Drought icon (the dying plant and land) into the TH file, without implementing it in the UI?
yes I will try to include Drought icon in font.
I include Drought icon in font with a83aa3173d874706cf2b6dac05c3b024b63dccd7 (not deployed). I plan to deploy this update next week.
I try to include upstream modification from 2.7.x branch but this breaks login page. Issue can be found here : https://github.com/GeoNode/geonode/issues/3172 I will try to revert updates from upstream
Update int and prod instance with:
2.7-gfdrr-ac3ab00-psycopg2.7 --> v1-20171109110306
I also introduce git tag to keep track of each rebase of gfdrr_rebase branch. Each rebase will introduce a new tag: vX whereX is a counter. Currently there is one tag : v1
@stufraser1 Icons are now synced with TH! on prod and int server.
Great, looks good. Thank you. Closing
Please add icons for additional hazards: