Listviews update

[ErikKBethke]

Update list view functions for layers and documents. Changes made were to include current date in filename through datetime, adding headers to file, and additional fields.

Would appreciate confirmation on whether filename will work in proposed format and if all field names are correct.

[ErikKBethke]

Changes were all made, looking for re-review to merge request.

[ErikKBethke]

Made a change to update deprecated field, but I noticed when running http://54.229.171.111/layers/list on the unmerged version of GeoNode that there are issues with unicode/ proxy compatibility. Do you think this will continue to be an issue? @Vampouille

[stufraser1]

@Vampouille Please advise if this can be merged now - we need to use the udpated list views for some tasks to update data and maps. thanks

[Vampouille]

@ErikKBethke Change from distribution_url to detail_url only impact layer objects. So you don't need to make change, changes are already made on https://github.com/GFDRR/geonode/tree/hosting (geonode 2.5). So can you revert https://github.com/GFDRR/geonode/pull/29/commits/41170777cd38a04e2b30265367aeeb5e83cd492a ?

This PR can be merged without last commit.

[stufraser1]

@Vampouille @ErikKBethke I reverted 4117077 as requested above (removed document.detail_url at line 534). No header for document.detail_url had been added

Please review and merge if acceptable

[Vampouille]

LGTM

[stufraser1]

@Vampouille I tried to run this, error still occurs at line 505: 'Document' object has no attribute 'distribution_url' Checking http://www.geonode-gfdrrlab.org/api/documents/ I see a detail_url but no distribution_url - so in fact this should be changed in documents as well as layers. Change committed

[stufraser1]

@Vampouille http://www.geonode-gfdrrlab.org/layers/list returns error: must be unicode, not proxy at location: /usr/src/app/geonode/layers/views.py in layer_list, line 521 Are you able to assist in resolving this please? I require this list view to work as soon as possible, to audit the data on the new geonode Thank you

[Vampouille]

I'm currently working on this feature but on new 2.6 upstream code. There is some "non ascii" characters in database, so we need to choose what to do with those characters. There is several choices :

• convert all non ascii characters to corresponding ascii character : "Stéphane" will be exported as "Stephane"
• export in utf8, most of non ascii characters should be correctly exported.
• export in another charset of your choice.

I would recommend second solution : export in UTF8 charset. @stufraser1 what is your preference ?

[stufraser1]

@Vampouille Happy to take your suggestion, if there are no issues with reading and editing UTF-8 in excel when the listview is exported to .csv - this will be the main use of it.

[Vampouille]

I finish to implements CSV export for layers on geonode 2.6 with this commit : https://github.com/camptocamp/labs_geonode/commit/b2a0a08ca7b35a302bdffbe8e31bd4560dd31052

[Vampouille]

@stufraser1 About document csv export, document does not have name field so following code : https://github.com/GFDRR/geonode/pull/29/files#diff-bc991905f1c7cd04b63504af988bc9c1R529 is not working. Can I just remove name field ?

[stufraser1]

Yes please remove name field if it does not exist

On Fri, 12 May 2017, 10:21 Julien Acroute, notifications@github.com wrote:

@stufraser1 https://github.com/stufraser1 About document csv export, document does not have name field so following code :

https://github.com/GFDRR/geonode/pull/29/files#diff-bc991905f1c7cd04b63504af988bc9c1R529 is not working. Can I just remove name field ?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/GFDRR/geonode/pull/29#issuecomment-301028076, or mute the thread https://github.com/notifications/unsubscribe-auth/AL724vcaiu9PtFuVuU3-i6LMVgC8Nk-aks5r5CSigaJpZM4M8y2b .

-- Stuart Fraser, PhD Disaster Risk Consultant www.disaster-risk.uk Skype: stu_fraser1 +44 (0)7455 048 044

[Vampouille]

@stufraser1 Can you check if you have all needed informations in following csv files :

documents_2017-05-12.xlsx layers_2017-05-12.xlsx

(On geonode, you will download CSV file, I had to convert csv to xlsx in order to add those files on github)

[stufraser1]

These files have everything we need. Thank you