search

GFDRR / open-risk-data-dashboard

Repository for the Open Data for Resilience Index, a website to track and improve the state of Open Data for Resilience worldwide.
https://index.opendri.org
GNU Lesser General Public License v3.0
23 stars 8 forks source link

Update Dataset - title check #364

Closed CIMAManuel closed 5 years ago

CIMAManuel commented 5 years ago

If title is "null" the check function doesn't check the field.

thom4parisot commented 5 years ago

Well, wasn't the title supposed to be optional?

CIMAManuel commented 5 years ago

I understand that field must be mandatory.

pzwsk commented 5 years ago

My mistake, we discussed it on Monday but it was not written in the related issue.

Title field should be optional indeed as there can be few cases where there is no dataset title (dataset does not exist, dataset do exist but with no clear or known title).

CIMAManuel commented 5 years ago

Ok, so we must to delete title's check in service.js file. If you agree I can use this branch to remove it.

pzwsk commented 5 years ago

Ok yes I agree

On Fri, Dec 14, 2018 at 1:55 PM Cavallaro Manuel notifications@github.com wrote:

Ok, so we must to delete title's check in service.js file. If you agree I can use this branch to remove it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GFDRR/open-risk-data-dashboard/issues/364#issuecomment-447317130, or mute the thread https://github.com/notifications/unsubscribe-auth/ACRKx2pAmhqNs2DxXhTryglHGE7jIlO5ks5u45_UgaJpZM4ZTTBY .