#371 explore countries, fix truncate reference when larger than 2 lines

[dedandy]

truncate explore countries references word wihen exceed 2 lines and substitute with 3 dots when there are.

Only in dataset_list.html, not in dataset_details.html, where adjust only semantic html

Looks like this:

[pzwsk]

Thanks for the tips Thomas,

also, requirement is to have similar height between rows whenever we have or two lines.

Thanks

On Thu, Dec 20, 2018 at 11:03 AM Thomas Parisot notifications@github.com wrote:

@oncletom commented on this pull request.

In frontend/css/rodi_css.css https://github.com/GFDRR/open-risk-data-dashboard/pull/377#discussion_r243214595 :

@@ -359,6 +359,24 @@ h1 + .lead { font-weight: 500; }

+ +/* +==============================================================================

• truncate lines +============================================================================== +*/

• +.trunkate {

There is already .single-line CSS class which does exactly this. And which works also for Firefox.

This snippet works only for Chrome.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/GFDRR/open-risk-data-dashboard/pull/377#pullrequestreview-186922712, or mute the thread https://github.com/notifications/unsubscribe-auth/ACRKx2tOmKhTJHWr3ZmJaE4QxPcgO8cVks5u62BTgaJpZM4Zbw49 .

[dedandy]

@pzwsk are you like this flow? ... here the table row, who have dataset_subtitles, have minimum height of 50px. Ever row has the same height.

[thom4parisot]

So it's not a problem if that works only in Chrome?

This is the result in Firefox.

The output is likely to be similar in Edge and Safari.

[dedandy]

Maybe I have an idea to fix this problem... 😉 tomorrow I'll try and test chrome/ff