search

GFDRR / open-risk-data-dashboard

Repository for the Open Data for Resilience Index, a website to track and improve the state of Open Data for Resilience worldwide.
https://index.opendri.org
GNU Lesser General Public License v3.0
23 stars 8 forks source link

Fix#257 #417

Closed pzwsk closed 5 years ago

pzwsk commented 5 years ago

Hi, could you check this please.

This is supposed to be a fix to #257 but I am always having answer as NO.

I think there is an issue in the param I am injecting in the expression but don't know how to do.

Thanks

fix #257

thom4parisot commented 5 years ago

I'm going to review this after the call.

thom4parisot commented 5 years ago

You were on the right track @pzwsk, but the datastructure varies between 2 pages, making the getQuestion_code useless.

I have refactored a few things to make it work with the 2 datastructures.

image image
pzwsk commented 5 years ago

Great thanks,

Is the issue related to having one controller.js per page?

Should we refactor and keep only one?

Overall, I found the structure of the code quite complex to navigate and understand.

thom4parisot commented 5 years ago

No it's related to the data structure returned by the API. A dataset has a different shape depending on the API resource. It is related to what I expressed in #325.

If "it works" and has no impact on the users, it not a priority to me at this stage of the project. It has/had an impact each time a newcomer joins the project, software wise.