Display countries list with new open data indicators

GFDRR / open-risk-data-dashboard

Repository for the Open Data for Resilience Index, a website to track and improve the state of Open Data for Resilience worldwide.

https://index.opendri.org

GNU Lesser General Public License v3.0

23 stars 8 forks source link

Display countries list with new open data indicators #424

Closed thom4parisot closed 5 years ago

thom4parisot commented 5 years ago

[x] display country open data indicators (fix #305)
[x] display available criteria data
[x] rewire the data with /api/scoring instead of /api/country_scoring (aligned with be_scoring-new branch)
[x] update sorting options

👁 Live Preview

thom4parisot commented 5 years ago

Here is what I'm up to. Some comments:

the ? progress bar is an information I understand will be provided by the API (the gap will be easy to fill)
shall we display or not display a progress bar which is empty? Shall I put "0" or not display it? (eg: Kenya "Restricted" datasets, Fiji "Open" datasets)

I also restored the tooltips! I found out they never worked. So we can imagine some nicer and more responsive texts than the browser default behaviour:

pzwsk commented 5 years ago

Hi Thomas, thanks looks very good,

regarding your comments:

the ? progress bar is an information I understand will be provided by the API (the gap will be easy to fill)

yes pending BE changes, cc @nastasi-oq

shall we display or not display a progress bar which is empty? Shall I put "0" or not display it? (eg: Kenya "Restricted" datasets, Fiji "Open" datasets)

I would not display it.

Also, great for the tooltips. Looks much better. If easy to do, I will probably have a check of where tooltips are needed and add them myself.

Thanks

thom4parisot commented 5 years ago

Done 👍 Data-wise, this is where I consume the data. It might give a hint to @nastasi-oq to output the data from the API:

https://github.com/GFDRR/open-risk-data-dashboard/blob/b29533ec29fb3ff56643f9ac7f5f39dc10b32e0c/frontend/countries.html#L186-L201

and

https://github.com/GFDRR/open-risk-data-dashboard/blob/b29533ec29fb3ff56643f9ac7f5f39dc10b32e0c/frontend/countries.html#L211-L216

Tooltip use case is located here, with ng-tooltip (custom module), title and data-placement (provided by Bootstrap):

https://github.com/GFDRR/open-risk-data-dashboard/blob/b29533ec29fb3ff56643f9ac7f5f39dc10b32e0c/frontend/countries.html#L186

By default, when not provided, the placement is "top", I think.

pzwsk commented 5 years ago

Thanks, merging now but may do some test then.

thom4parisot commented 5 years ago

@pzwsk can you wait until I incorporate #305 changes first? It will give us a more realistic output.

thom4parisot commented 5 years ago

The latest push is wired with the new API.

👁 You can try it here

One subtle change I noticed: datasets_count now returns the full number of datasets uploaded, instead of the number of key datasets with at least one dataset.

It's nice!

pzwsk commented 5 years ago

This is great, thanks.

Can we merge this version now?

Also, I had a conversation with @vdeparday yesterday. He would like to test the Unknownindicator combined with the others. I would like to do some testing and discuss together then.

Thanks

thom4parisot commented 5 years ago

Done 👍 It is available on dev.riskopendata.org.