search

GFDRR / open-risk-data-dashboard

Repository for the Open Data for Resilience Index, a website to track and improve the state of Open Data for Resilience worldwide.
https://index.opendri.org
GNU Lesser General Public License v3.0
23 stars 8 forks source link

BE implement new scoring system (all countries view only) #428

Closed nastasi-oq closed 5 years ago

nastasi-oq commented 5 years ago

With this PR we provide a new data structure for all countries, included score and rank. It provide data for #305

pzwsk commented 5 years ago

Thanks @nastasi-oq

I understand removing score for dataset and implementing decision tree will be done later then?

nastasi-oq commented 5 years ago

@pzwsk

I understand removing score for dataset

Not necessarily, we can add it in this PR

and implementing decision tree will be done later then?

It is already there with help of scoring currently (but is trivial change it to be pure decision tree)

nastasi-oq commented 5 years ago

@pzwsk scoring, ranking and sorting disabled, dev. frontend (that seems to point to exp. Backend at this moment) seems not implement sorting yet, is it correct ?

pzwsk commented 5 years ago

Hi, as discussed, to me you can merge but we need to get rid of calls to api/country_scoring/ frontend side to be perfectly aligned with new indicators.

I am going to open a new issue for that.

thom4parisot commented 5 years ago

api/country_scoring is in use in the dataset_list.html page, and it also returns the list of datasets.

thom4parisot commented 5 years ago

@nastasi-oq is this route https://exp.riskopendata.org/api/scoring/AU supposed to output results? Because at the moment it throws an error but I'm not sure if it's because i'm not supposed to call it this way.

nastasi-oq commented 5 years ago

@nastasi-oq is this route https://exp.riskopendata.org/api/scoring/AU supposed to output results? Because at the moment it throws an error but I'm not sure if it's because i'm not supposed to call it this way.

@oncletom no, I want to manage it in a separate PR, you must continue to use the old /api/country_scoring/<country_id> address at this stage.