search

GFDRR / open-risk-data-dashboard

Repository for the Open Data for Resilience Index, a website to track and improve the state of Open Data for Resilience worldwide.
https://index.opendri.org
GNU Lesser General Public License v3.0
23 stars 8 forks source link

Dataset_list.html (single country page): filters not working #453

Closed pzwsk closed 5 years ago

pzwsk commented 5 years ago

In example below, only risk category data should be selected

image

pzwsk commented 5 years ago

Question to @CIMAManuel and @oncletom: is there an easy fix we can implement before Feb 28? If yes let's do it, otherwise I prefer to spend time on reviewing filtering feature.

Related to similar issue on Explore countries page.

Thanks

thom4parisot commented 5 years ago

Indeed.

There a 2 problems.

A quick one: the applicability filters are broken. The category ones are fine. It should be fairly easy to fix before the 28th.

Another problem is: even if the filter works, it happens api/country is not implemented as it used to be. The API parameters we used have no effect on the response. Eg: https://index.opendri.org/api/scoring/MW?category=Vulnerability

I checked for a quicker solution but we have no way to filter from the client-side. The quickest fix (both in implementation and UX) would be to provide the categories and applicability for each dataset of the response.

I think it's a quite sensible move to do, considering we do not have to recompute the score for each request (it was the reason why the filtering was done server-side).

What do you think @nastasi-oq?

pzwsk commented 5 years ago

Hi @nastasi-oq could you have a quick look?

Many thanks

thom4parisot commented 5 years ago

@pzwsk did you have a look at #462? If it is suitable, there is no need to do backend work.