search

GFDRR / rdl-data

Challenge Fund Database combining Hazard, Exposure, Loss and Vulnerability schema into a single database
GNU Affero General Public License v3.0
1 stars 2 forks source link

add purpose and notes fields to mover #20

Closed stufraser1 closed 3 years ago

stufraser1 commented 3 years ago

Hazard/ged4all/loss.contribution.purpose Hazard/ged4all/loss.contribution.notes

Does not exist in mover - improve consistency by adding this

stufraser1 commented 3 years ago

Could be done by adding additional Contribution table to MOVER. @ConnectedSystems can it be done in SQL alchemy version?

matamadio commented 3 years ago

Added to docs: mover.contribution like the other ones. Should we make "contribution" a global table that each sub-set can relate to?

ConnectedSystems commented 3 years ago

If Contribution is intended to hold the same data, then it should be part of the common schema.

~Note that the f_core (which I am taking to be the Contribution table for the Vulnerability/Mover schema) has additional, possibly context-specific fields.~

I've added notes, version and purpose fields for now but it would be good for this to be standardized.

EDIT: I see now that a separate contribution table has been added to Vulnerability. @MamadioCMCC and I will do a review to remove any possible duplicates between the two.

stufraser1 commented 3 years ago

Prefer to have consistent table then remove duplicate fields from f_core, though only if they are not more specific to vulnerability data, I can review any unsure about

On Wed, 20 Jan 2021, 08:01 Takuya Iwanaga, notifications@github.com wrote:

If Contribution is intended to hold the same data, then it should be part of the common schema.

Note that the f_core (which I am taking to be the Contribution table for the Vulnerability/Mover schema) has additional, possibly context-specific fields.

I've added notes, version and purpose fields for now but it would be good for this to be standardized.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GFDRR/rdl-data/issues/20#issuecomment-763413725, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7PNYSNA2OP6VUZG25QIEDS22EVBANCNFSM4UJEUMJQ .