GFDRR / rdl-jkan

A lightweight, backend-free open data portal, powered by Jekyll
http://jkan.riskdatalibrary.org/
MIT License
1 stars 0 forks source link

Review of MVP and fixes #13

Closed matamadio closed 1 day ago

matamadio commented 3 years ago

More comments from my test uploading datasets. Most are small fixes.

Schema options and descriptions

General and cosmetic stuff

Under discussion: add creator field to contribution As suggested in the exchange with Giuseppe, we should have maintainer and creator (and relative contact email) as separate entities. That would also bring us one attribute closer to dublincore standard: 1) creator, 2) publisher and 3) contributor (mainteiner). @stufraser1 to confirm.

ConnectedSystems commented 3 years ago

"Would be possible to have hint of fields content in grey?"

Yes, but so far only for text fields.

You add a "placeholder" field for each item in rdl.yml

"Force field description width (when purpose field gets big, label colunn shrinks too much)"

Suggest we get someone with more experience with bootstrap/responsive design to do this

matamadio commented 3 years ago

Great job; all working as expected. Some minor improvement:

ConnectedSystems commented 3 years ago

"may need to allow more fields to include multiple values, but not confirmed yet; is it hard?"

Depending on the field. It largely is doable but can have implications/complications which require changes to be made all over the code base.

As for the Schema component display position I will leave that til next week as it is fairly low priority

matamadio commented 3 years ago

Because many packages are together in a page, I think is useful to:

ConnectedSystems commented 3 years ago

The following outstanding items will be addressed at a later date:

These can be raised again in a future issue so I am closing this one.

matamadio commented 3 years ago

After conversation with Stu:

Reopening thread for the purpose of team review.

matamadio commented 3 years ago

immagine immagine

matamadio commented 3 years ago

Couple of bugs: