search

GFDRR / rdl-standard

The Risk Data Library Standard (RDLS) is an open data standard to make it easier to work with disaster and climate risk data. It provides a common description of the data used and produced in risk assessments, including hazard, exposure, vulnerability, and modelled loss, or impact, data.
https://docs.riskdatalibrary.org/
Creative Commons Attribution Share Alike 4.0 International
13 stars 1 forks source link

[Schema] group remaining issues into single PRs based on component #118

Closed odscjen closed 1 year ago

odscjen commented 1 year ago

There's currently 20 outstanding issues on the project board, 2 of which are waiting on Mattia's agreement.

For the others I recommend we tackle them grouped by component as:

a) some of them are very small changes b) some of them are changes that on their own are a bit incoherent.

Grouping them this way gives us the following:

Top level #68 #79 https://github.com/GFDRR/rdl-standard/issues/53 some general minor changes from spreadsheet https://github.com/GFDRR/rdl-standard/issues/94

Hazard https://github.com/GFDRR/rdl-standard/issues/95 https://github.com/GFDRR/rdl-standard/issues/82 plus some general minor changes from spreadsheet https://github.com/GFDRR/rdl-standard/issues/94 still being discussed https://github.com/GFDRR/rdl-standard/issues/59 https://github.com/GFDRR/rdl-standard/issues/91 https://github.com/GFDRR/rdl-standard/issues/5 - partly addressed by https://github.com/GFDRR/rdl-standard/pull/114 https://github.com/GFDRR/rdl-standard/issues/96 https://github.com/GFDRR/rdl-standard/issues/73 - codelist definitions in https://github.com/GFDRR/rdl-standard/issues/75#issuecomment-1613213583 https://github.com/GFDRR/rdl-standard/issues/72 - codelist https://github.com/GFDRR/rdl-standard/issues/69 - adding an id https://github.com/GFDRR/rdl-standard/issues/70 - adding an id https://github.com/GFDRR/rdl-standard/issues/60 https://github.com/GFDRR/rdl-standard/issues/81

Vulnerability https://github.com/GFDRR/rdl-standard/issues/74 - codelist https://github.com/GFDRR/rdl-standard/issues/75 some codelists in this, the descriptions of which are being dealt with in https://github.com/GFDRR/rdl-standard/issues/112 https://github.com/GFDRR/rdl-standard/issues/78 - I’ve already started on this https://github.com/GFDRR/rdl-standard/issues/56 - just a ticket to remove some fields https://github.com/GFDRR/rdl-standard/issues/76 - codeslist https://github.com/GFDRR/rdl-standard/issues/77 - codelist plus some general minor changes from spreadsheet https://github.com/GFDRR/rdl-standard/issues/94

Loss No specific issues for Loss, most big changes covered by other issues (i.e. reusing objects/fields created for other components) or are minor updates agreed in spreadsheet https://github.com/GFDRR/rdl-standard/issues/94

I recommend leaving Loss to the end as the bulk of the changes there relate to codelists and objects that are being created as part of other components.

Hazard has a lot but many of these are small changes, e.g. adding in id fields and where big changes are required they've been well discussed in the issues.

odscjen commented 1 year ago

I'm going to tackle Vulnerability today so I'll assign myself all of those issues

odscjen commented 1 year ago

All of the Vulnerability issues are now in a branch but I'm holding off on creating the PR until #101 has been merged as it needs the Cost object to be there.

72 is also included in this branch as it's referenced in vulnerability too.

odscjen commented 1 year ago

I'm working on the top level ones now too :)

https://github.com/GFDRR/rdl-standard/pull/119

odscjen commented 1 year ago

@odscrachel is working on the Hazard issues

odscjen commented 1 year ago

I'll start working on Loss with the understanding that it won't be ready for PR until the rest have been merged