Closed odscjen closed 1 year ago
Re. this 3rd item, @duncandewhurst how do we do that?
You need to edit the relevant lines of schema.md
, for example, for loss:
The collapse
option accepts a comma-separated list of keys to collapse in the schema table generated by the directive.
In order to keep the table lengths manageable generally, we want to collapse keys that reference a definition since each definition has its own schema table under the sub-schemas heading on the reference page.
So for loss, you would collapse cost
and impact
since they reference the Cost
and Impact
definitions respectively, e.g.
collapse: cost,impact
I think I checked the right bit of the collapse and it had all the fields listed, not sure if that was correct...
The enum
for Loss.category
needs to be updated, per https://github.com/GFDRR/rdl-standard/pull/124#issuecomment-1626343055
My approval is subject to @stufraser1's comments being resolved to his satisfaction :-)
Related issues
closes https://github.com/GFDRR/rdl-standard/issues/126
Updates Loss component.
Removes
time_start
,time_end
andtime_year
as they are all covered in the top leveltemporal
object.Needs the
Vulnerability
PR (https://github.com/GFDRR/rdl-standard/pull/124) to be merged first as it contains theImpact
object referenced byLoss
.Merge checklist
./manage.py
pre-commitIf you added or removed a field:
collapse
option of the jsonschema directives for dataset, resource, hazard, exposure, vulnerability and loss onreference/schema.md
Re. this 3rd item, @duncandewhurst how do we do that?