GFDRR / rdl-standard

The Risk Data Library Standard (RDLS) is an open data standard to make it easier to work with disaster and climate risk data. It provides a common description of the data used and produced in risk assessments, including hazard, exposure, vulnerability, and modelled loss, or impact, data.
https://docs.riskdatalibrary.org/
Creative Commons Attribution Share Alike 4.0 International
16 stars 1 forks source link

create loss object and loss_type.csv #132

Closed odscjen closed 1 year ago

odscjen commented 1 year ago

Related issues

closes https://github.com/GFDRR/rdl-standard/issues/126

Updates Loss component.

Removes time_start, time_end and time_year as they are all covered in the top level temporal object.

Needs the Vulnerability PR (https://github.com/GFDRR/rdl-standard/pull/124) to be merged first as it contains the Impact object referenced by Loss.

Merge checklist

If you added or removed a field:

Re. this 3rd item, @duncandewhurst how do we do that?

duncandewhurst commented 1 year ago

Re. this 3rd item, @duncandewhurst how do we do that?

You need to edit the relevant lines of schema.md, for example, for loss:

https://github.com/GFDRR/rdl-standard/blob/71296b83b7f087b575f4c4e271826a72d28aec3e/docs/reference/schema.md?plain=1#L390

The collapse option accepts a comma-separated list of keys to collapse in the schema table generated by the directive.

In order to keep the table lengths manageable generally, we want to collapse keys that reference a definition since each definition has its own schema table under the sub-schemas heading on the reference page.

So for loss, you would collapse cost and impact since they reference the Cost and Impact definitions respectively, e.g.

collapse: cost,impact
odscjen commented 1 year ago

I think I checked the right bit of the collapse and it had all the fields listed, not sure if that was correct...

duncandewhurst commented 1 year ago

The enum for Loss.category needs to be updated, per https://github.com/GFDRR/rdl-standard/pull/124#issuecomment-1626343055

duncandewhurst commented 1 year ago

My approval is subject to @stufraser1's comments being resolved to his satisfaction :-)