Open stufraser1 opened 1 year ago
Just dipping in here to say the reason the test are failing is an issue with the CSV file. If you click on 'Details' to the right of "Run all tests/test (push)" and scroll up to "warnings summary" it'll show you what it thinks the CSV should look like. In this case you've put quotation marks around the final sentence (Value of economic indicator or development index.) but it doesn't need them as there are no special characters in the sentence.
Because sometimes the license is appropriate for data only other times it can apply to text content / document and data
From: Mattia Amadio @.> Sent: Thursday, April 11, 2024 9:43:50 AM To: GFDRR/rdl-standard @.> Cc: Stuart Fraser @.>; Author @.> Subject: Re: [GFDRR/rdl-standard] Update exposure_category.csv (PR #256)
@matamadio approved this pull request.
For my knowledge, why is there "Content,data" instead of Data like in other rows?
— Reply to this email directly, view it on GitHubhttps://github.com/GFDRR/rdl-standard/pull/256#pullrequestreview-1993617562, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC7PNYQ2CRVGRYKENLQ6OELY4ZEMNAVCNFSM6AAAAAA5BITNLCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOJTGYYTONJWGI. You are receiving this because you authored the thread.Message ID: @.***>
Suggestion to include indicator of economic value (e.g. GDP) and social(+economic) development (e.g. HDI) into exposure_category codelist - this is a gap that surfaced when adding some GFDRR exposure data (R5 project): _economic_indicator,Economic Indicator,"Economic activity and growth, including measures of economic value such as Gross Domestic Product (GDP)." developmentindex,Development Index,"Social development, or social and economic development, such as the Human Development Index (HDI)."
Codelist metric_dimension then requires an index value - suggestion made: _indicator_indexvalue,Indicator or index value,"Value of economic indicator or development index."
Codelist quantity_kind has no corresponding value to use with exposure that includes a unitless index value, such as HDI: how to address this in the required field?
Merge checklist
If you added, removed or renamed a field:
collapse
option of the jsonschema directives for dataset, resource, hazard, exposure, vulnerability and loss onreference/schema.md
reference/schema/md
examples
Always:
./manage.py
pre-commitHaving trouble?
See how to resolve check failures.