search

GFDRR / thinkhazard

ThinkHazard!
http://thinkhazard.org/
GNU General Public License v3.0
32 stars 19 forks source link

Add the data source name to 'unavailable source' text #833

Closed stufraser1 closed 6 years ago

stufraser1 commented 6 years ago

Possible to add the data source to the text 'The data used to classify the hazard in this area is not publicly available to view or download due to licensing restrictions.'

Can we use metadata field 'data owner', to add in the firm name, to make the text: 'The data used to classify the hazard in this area is not publicly available to view or download due to licensing restrictions. Contact [data owner] for further information'

tonio commented 6 years ago

Deployed on integration. screenshot from 2018-03-16 14-52-53

stufraser1 commented 6 years ago

Looks great, thank you. Is it possible to include at the firm name, a hyperlink to the firm's website (e.g. the same one used in the 'About page')?

fjacon commented 6 years ago

The problem is that we do not have the hyperlink in the database. We could have a method to rebuild this link by matching with the link we have in the "about" page. But it will not work for all cases. If the match fails we would have no link. Is that OK ?

stufraser1 commented 6 years ago

Understood. The naming is the key part for now. Happy to deploy that. Perhaps we can have an independent lookup of firm name and url, but the best method and place to store/maintain this lookup needs consideration (i.e. in layer metadata or in thinkhazard). Ok to deploy the name alone and update with url later, if you're happy to do so.

tonio commented 6 years ago

OK. As the template has changed, translation will need update. Should I push translations from integration (ie prod DB is unchanged), or deploy to production & then push to tx from production? In that case, untranslated (english) text will be shown until translation is done.

stufraser1 commented 6 years ago

Please push from int, I will update transifex and let you know when done, to deploy to production

tonio commented 6 years ago

ui messages have been extracted & pushed to transifex from int.

stufraser1 commented 6 years ago

All amended strings (for this issue and other changes in About page) have been translated. Please pull translated strings.

stufraser1 commented 6 years ago

@tonio Two open PRs will also require a new push of strings to transifex: #842 and #841 Please can you merge those PR as soon as possible, and push untranslated strings to transifex? I will update the translations ready for pulling back to TH all strings together.

tonio commented 6 years ago

@stufraser1 PR have been fixed & merged, I just push new strings to transifex from int. I'll be able to update prod as soon as new strings are translated.

On 5 April 2018 at 12:19, Stuart Fraser notifications@github.com wrote:

@tonio https://github.com/tonio Two open PRs will also require a new push of strings to transifex: #842 https://github.com/GFDRR/thinkhazard/pull/842 and #841 https://github.com/GFDRR/thinkhazard/pull/841 Please can you merge those PR as soon as possible, and push untranslated strings to transifex? I will update the translations ready for pulling back to TH all strings together.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GFDRR/thinkhazard/issues/833#issuecomment-378888897, or mute the thread https://github.com/notifications/unsubscribe-auth/AABUtmlEmeyNEODC0W9LtFFWSLTyI_zSks5tle_FgaJpZM4SLmiC .

-- Antoine Abt

Camptocamp France SAS http://www.camptocamp.com

stufraser1 commented 6 years ago

New strings are translated. Thanks

tonio commented 6 years ago

Master branch (tag v2.0.10 from today) has been deployed to production, and translations have been pulled.