GFG / bloom-filter

RocketLabsBloomFilter by Ulf Kirsten
https://www.rocket-internet.de
MIT License
19 stars 4 forks source link

Test failures. #1

Open bangpound opened 7 years ago

bangpound commented 7 years ago

When I run the tests in this project with PHP 7.1, I get two failures. The actual results from the Jenkins hash function don't match what is expected.

There were 2 failures:

1) RocketLabs\BloomFilter\Test\Hash\BloomFilterTest::addBulkFilter
Expectation failed for method name is equal to <string:setBulk> when invoked 1 time(s)
Parameter 0 for invocation RocketLabs\BloomFilter\Persist\Persister::setBulk(Array (...)) does not match expected value.
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
     4 => 451
-    5 => 157
+    5 => 980
     6 => 905
     7 => 698
     8 => 186
 )

/src/BloomFilter/BloomFilter.php:106
/tests/BloomFilterTest.php:125

2) RocketLabs\BloomFilter\Test\Hash\BloomFilterTest::DoesNotExistInFilter
Expectation failed for method name is equal to <string:setBulk> when invoked 1 time(s)
Parameter 0 for invocation RocketLabs\BloomFilter\Persist\Persister::setBulk(Array (...)) does not match expected value.
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => 1008
     1 => 193
-    2 => 573
+    2 => 952
 )

/src/BloomFilter/BloomFilter.php:93
/tests/BloomFilterTest.php:170

FAILURES!
Tests: 29, Assertions: 42, Failures: 2.

Are the test expectations wrong? If so, I can open a PR to address it.

reedy commented 7 years ago

OOI, does it break on older PHP versions?