GFNOrg / gflownet

Generative Flow Networks
MIT License
602 stars 76 forks source link

About handling parent molecules in samples list #15

Open Srilok opened 1 year ago

Srilok commented 1 year ago

Hello,

In mols/glfownet.py, I noticed that you include the parents of m in samples list in _get_sample_model() (line 197 and line 203)

However, in the case we sample a null action (action==0), we only add m and not its parents (line 182). Is this a mistake, or am I missing something? Why is this case treated differently?

Thank you