Easier environment definition

[josephdviviano]

• added helper functions to DiscreteEnv to make mask definition easier.
• added helper function for mask casting to base class.
• changed default behaviour of the log_reward and reward methods.

[saleml]

Also, it seems like there are GitHub actions now. Do you happen to know why the checks fail ?

[josephdviviano]

no it's some kind of environment thing -- I'm going to fix that as part of this PR once and for all :) Joseph Viviano @josephdviviano https://twitter.com/josephdviviano viviano.ca

On Mon, Oct 23, 2023 at 3:50 PM saleml @.***> wrote:

Also, it seems like there are GitHub actions now. Do you happen to know why the checks fail ?

— Reply to this email directly, view it on GitHub https://github.com/GFNOrg/torchgfn/pull/143#issuecomment-1775915268, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7TL2RV5FTAX3WJSCBUV7LYA3C6VAVCNFSM6AAAAAA6JLNRN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZVHEYTKMRWHA . You are receiving this because you were assigned.Message ID: @.***>

[josephdviviano]

All comments fixed -- just waiting to see if the checks pass :)

[josephdviviano]

Tests pass!

[saleml]

Should this be merged to master or to stable ? I thought the logic is: put everything in master, and once we're happy with master, we push master to stable.