log_rewards = trajectories.log_rewards
# TODO: log_reward_clip_min isn't defined in base ().
if math.isfinite(self.log_reward_clip_min) and log_rewards is not None:
log_rewards = log_rewards.clamp_min(self.log_reward_clip_min)
this logic corresponds to an attribute only defined in subclasses. I don't think this is best practice, and the corresponding subclass logic should be centralized in base.py.
in
base.py
this logic corresponds to an attribute only defined in subclasses. I don't think this is best practice, and the corresponding subclass logic should be centralized in
base.py
.