Open hyeok9855 opened 1 week ago
Thanks for your ideas!
GFNModule
although I'm worried this might be a footgun down the line if some method requires that modularity. @saleml thoughts? src/gfn/gym/helpers
in general. I feel like the "helpers" should either be integrated into the main library or the individual gym
files, and the whole folder should be removed. I think we could also explore integrating the sampler completely within the GFNModule
Yes! Let's discuss this in #195 about it :)
After reviewing the codes, I brought two possible refactoring ideas.
Move the parameter
preprocessor
inGFNModule
toSampler.
This could separateenv
fromGFNModule
(since thepreprocessor
is defined inenv
) and pass the preprocessed states to theGFNModule.
One drawback is that the input ofGFNModule
would not beState
anymore.There are two preprocessor files:
src/gfn/preprocessors.py
andsrc/gfn/gym/helpers/preprocessors.py.
If this is not intended, it would be better to merge them into one file.These are naive suggestions, so please feel free to comment, and let's discuss!