GFNOrg / torchgfn

A modular, easy to extend GFlowNet library
https://torchgfn.readthedocs.io/en/latest/
Other
236 stars 31 forks source link

`Estimator`s make too many assumptions about the shapes of outputs. #214

Open josephdviviano opened 1 week ago

josephdviviano commented 1 week ago

Right now, the estimator output dim checker only looks at the final output dimension. It is implicitly assuming we are calculating something that looks like a 1-d distribution. I believe this might be too restricting for all possible Estimator use cases, but it is not currently a priority.

saleml commented 15 hours ago

Thanks for raising this. Have you ever stumbled upon a case where an error was raised for this reason?