GFZ / arosics

AROSICS - Automated and Robust Open-Source Image Co-Registration Software
https://git.gfz-potsdam.de/danschef/arosics
Apache License 2.0
137 stars 26 forks source link

perf: minor performance improvements #38

Closed roelofvandijkO closed 3 months ago

roelofvandijkO commented 3 months ago
danschef commented 3 months ago

@roelofvandijkO Why did you close this PR? To me, it looks like it includes some very useful improvements.

roelofvandijkO commented 3 months ago

@danschef It was opened by accident - should have been on my fork. :)

I understood that Gitlab is where issues/PRs are tracked. What do you prefer?

For instance, I'm working on sharedmemory instead of globals here: https://git.gfz-potsdam.de/danschef/arosics/-/issues/102

danschef commented 3 months ago

Yes, correct. The GitHub repo is just a mirror and PRs should go to GitLab where the CI is running. However, for externals without a GitLab account, I think it is not possible to open a GitLab merge request. But I could clone the your changes to GitLab and merge it there.