GFlisch / Arc4u.Guidance.Doc

Other
5 stars 1 forks source link

YARP reverseproxy.json timeout configuration generated by Guidance is incorrect. #118

Closed vvdb-architecture closed 1 year ago

vvdb-architecture commented 1 year ago

Currently, we have something like this generated by default by the Guidance:

        "HttpClient": {
          "MaxConnectionsPerServer": 16,
          "Timeout": "00:10:00"
        },

The Timeout has no effect: it's not part of the HttpClient configuration. So it stays the default of 100 seconds, regardless which timeout setting you apply to your HttpClient.

To correct this, remove the Timeout property from the HttpClient and use the ActivityTimeout in HttpRequest like this:

        "HttpClient": {
          "MaxConnectionsPerServer": 16,
        },
        "HttpRequest": {
          "Version": "2.0",
          "VersionPolicy": "RequestVersionOrHigher",
          "ActivityTimeout": "00:10:00"
        },

Reference: https://microsoft.github.io/reverse-proxy/articles/http-client-config.html#httprequest

GFlisch commented 1 year ago

Implemented in the next version