GFlisch / Arc4u.Guidance.Doc

Other
5 stars 1 forks source link

Generated BuildAndPublish.yml doesn't include gitversion #165

Closed refactorinc closed 6 months ago

refactorinc commented 1 year ago

Describe the solution you'd like The BuildAndPublish.yml is not configured for gitversion following current guidelines/conventions/agreements Ideally gitversion is configured for all new projects

Describe alternatives you've considered Doing this manually but it takes time and something else does not get done.

rdarko commented 1 year ago
HaGGi13 commented 1 year ago

As described in the first task of the previous comment the used template parameter list in the hook-in template (BuildAndPublish.yml) must be extended by: gitversionEnabled: false
By the way, this is the default value.

Following a more complete example (note the last line):

stages:
- template: Build/BuildAndPublish.yml@templates
  parameters:
    serviceName: MyService
    projectName: MyProject
    folderPrefix: ''
    sonarQubeEnabled: false
    collectCodeCoverage: true
    publishTestResult: false
    publishCodeCoverageResult: false
    gitversionEnabled: false
GFlisch commented 10 months ago

@HaGGi13 . Is the GitVersion not have to be set to true?

HaGGi13 commented 10 months ago

@HaGGi13 . Is the GitVersion not have to be set to true?

It depends on if you want to have GitVersion enabled by default for newly created projects. It's possible to enable it in the build template itself, so that it's enabled for all builds by default - opposite of current situation. Unfortunately, I cannot estimate the impact it will have.

rdarko commented 8 months ago

set gitVersionEnabled: false